Bugzilla@Mozilla – Bug 528134
inDOMUtils::GetRuleNodeForContent can hand back a dead rulenode
Last modified: 2010-05-09 16:25:45 PDT
Summon comment box
See bug 527567 comment 5.
Created attachment 411888 [details] [review] Fix Zack, do you prefer r=zwol, or r=zweinberg, or something else?
A bunch of tabs snuck in to that patch (making the lines look misindented).
Good catch. Fixed locally.
Comment on attachment 411888 [details] [review] Fix r=dbaron We should really get this in on 1.9.2...
http://hg.mozilla.org/mozilla-central/rev/d5a6793282b0
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2707b779b74a
Created attachment 414451 [details] [review] 1.9.1/1.9.0 merge Applies on 1.9.0 with -F3.
Comment on attachment 414451 [details] [review] 1.9.1/1.9.0 merge r=dbaron
These bugs landed after b4 was cut. Moving flag out.
*** Bug 527567 has been marked as a duplicate of this bug. ***
Comment on attachment 414451 [details] [review] 1.9.1/1.9.0 merge Approved for 1.9.1.7 and 1.9.0.17, a=dveditz for release-drivers
*** Bug 532539 has been marked as a duplicate of this bug. ***
Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/35d5359743c3 Checked into CVS: Checking in layout/inspector/src/inDOMUtils.cpp; /cvsroot/mozilla/layout/inspector/src/inDOMUtils.cpp,v <-- inDOMUtils.cpp new revision: 1.42; previous revision: 1.41 done Checking in layout/inspector/src/inDOMUtils.h; /cvsroot/mozilla/layout/inspector/src/inDOMUtils.h,v <-- inDOMUtils.h new revision: 1.13; previous revision: 1.12 done Checking in layout/style/nsIInspectorCSSUtils.h; /cvsroot/mozilla/layout/style/nsIInspectorCSSUtils.h,v <-- nsIInspectorCSSUtils.h new revision: 1.12; previous revision: 1.11 done Checking in layout/style/nsInspectorCSSUtils.cpp; /cvsroot/mozilla/layout/style/nsInspectorCSSUtils.cpp,v <-- nsInspectorCSSUtils.cpp new revision: 1.37; previous revision: 1.36 done Checking in layout/style/nsInspectorCSSUtils.h; /cvsroot/mozilla/layout/style/nsInspectorCSSUtils.h,v <-- nsInspectorCSSUtils.h new revision: 1.13; previous revision: 1.12
Created attachment 423780 [details] [review] 1.8.0 version
David or Boris, how can QA verify this fix? For the given signature in the summary no crashes are listed at all. For which signature I would have to search?
See bug 527567.
(In reply to comment #16) > See bug 527567. I'm not able to reproduce the crash with an 3.5.7 build and the Google Page Speed addon installed. Looks like we have to wait for the beta cycle or the release to check the crash stats.
It should be hard to reproduce without frame poisoning.