Bugzilla@Mozilla – Bug 479288
Lack of XOW
Last modified: 2009-07-21 17:26:50 PDT
Summon comment box
This seems to be a regression from bug 460882. When accessing a window by using __parent__ property or valueOf.call(), the window is not wrapped in XOW. Sorry if this is a duplicate of bug 478910 or bug 479211.
This is mine, really. I'm sure bent won't mind me stealing it.
sg:high at least, sg:critical if there's a way into a privileged about: page or similar.
Created attachment 363204 [details] [review] Proposed fix This should fix it. It still needs a run against Dromaeo to ensure I'm not actually slowing anything down.
Created attachment 363217 [details] [review] Updated to bent's comments Bent convinced me that the thisObject hook was the way to go and that we should call OBJ_TO_OUTER_OBJECT from the thisObject hook in XPConnect.
Comment on attachment 363217 [details] [review] Updated to bent's comments Looks great! No significant differences on dromaeo.
Taking off the 1.9.0.8 blocking list until we've got a handle on all the remaining regressions of bug 460882.
http://hg.mozilla.org/mozilla-central/rev/839f915de914
*** Bug 479924 has been marked as a duplicate of this bug. ***
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b731d0bcadac
Does this bug actually apply to 1.9.0? I don't see a checkin for CVS above for 1.9.0 and testing with the testcase with 1.9.0.11, the bug doesn't reproduce.
Al, this is the same as bug 481434 in that it won't affect 1.9.0.11, but the patch was needed when we landed bug 460882 on the 1.9.0 branch to avoid introducing this regression there.