Bugzilla@Mozilla – Bug 657201
WebGL crash [@createProgram/@gldCopyTexSubImage]
Last modified: 2011-07-12 08:26:38 PDT
Summon comment box
Created attachment 532499 [details] testcase Sometimes it crashes in createProgram, sometimes in gldCopyTexSubImage. The bug is currently only reproducible against: ProductName: Mac OS X ProductVersion: 10.6.7 BuildVersion: 10J869 OpenGL renderer string: ATI Radeon HD 6750M OpenGL Engine OpenGL version string: 2.1 ATI-1.6.32 I have marked this as a security issue because I get some write violations at different places.
Created attachment 532500 [details] callstack1-read-0
Created attachment 532501 [details] callstack2-write-0
Created attachment 532502 [details] callstack3-write-value.txt
Oh oh, really interesting! All 3 crashes have in common to be happening inside of glValidateProgram(). In bug 593867, we already decided to avoid calling glValidateProgram on Macs with NVIDIA cards. Now you're getting problems with a ATI card --> let's completely avoid glValidateProgram() which means that it wasn't NVIDIA specific.
Chris, I had filed Apple bug 9129482, but it got closed as "missing information". It seems that this bug could use some pushing by an Apple insider ;-)
Created attachment 532643 [details] [review] really disable validateProgram() on Mac
Note: it's also very interesting to have this on Mac OS 10.6.7. My Apple bug got closed as I was unable to confirm whether it still happened on 10.6.7.
Fixed - thanks Benoit.
We should keep this bug open until it's actually fixed in the tree! Please review my patch or tell me if you would like me to find someone else.
Oh. Sorry for closing it to early. I already reviewed your patch, applied it to my build and checked it against the provided testcase. ;)
Welcome to Mozilla bureaucracy: if you approve my patch, please click 'Details', then on the 'review' line, select '+'. Then we will land it, paste here a link to the changeset, and finally close this bug.
Comment on attachment 532643 [details] [review] really disable validateProgram() on Mac Please land this change on both Aurora and Beta. (In the future, getting changes in during Aurora will save you this extra step.)
mozilla-central: http://hg.mozilla.org/mozilla-central/rev/9ca849387799 I didn't realize that this was now sg-critical, sorry. Will land on aurora and beta ASAP.
Pushed to Beta: http://hg.mozilla.org/releases/mozilla-beta/rev/eba2dce26189 The fix was already on Aurora, as the Central->Aurora merge happened since I landed on Central.